[Fix #500] Mark Performance/MapCompact cop as unsafe
#501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
May 21, 2025
| @@ -1269,7 +1269,7 @@ This cop identifies places where `map { ... }.compact` can be replaced by `filte | |||
| [#safety-performancemapcompact] | |||
| === Safety | |||
|
|
|||
| This cop's autocorrection is unsafe because `map { ... }.compact` might yield | |||
| This cop is unsafe because `map { ... }.compact` might yield | |||
There was a problem hiding this comment.
This docs/modules/ROOT/pages/cops_performance.adoc is auto-generated. Can you update the source code document instead? Also, no update to docs/modules/ROOT/pages/cops_performance.adoc is needed.
There was a problem hiding this comment.
Hi @koic, thanks for the review. I have updated the PR as requested. Cheers.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance/MapCompactis marked as safe but it should not be as the suggested refactoring is not equivalentThis is confusing for new Ruby developers.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.